Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve svm landing time metric #373

Merged
merged 5 commits into from
Feb 5, 2025
Merged

fix: improve svm landing time metric #373

merged 5 commits into from
Feb 5, 2025

Conversation

guibescos
Copy link
Contributor

@guibescos guibescos commented Jan 31, 2025 •
edited
Loading

  • make buckets that match what we see in production better
  • start measuring before the first send_transaction

@vercel Vercel
Copy link

vercel bot commented Jan 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swap-staging ❌ Failed (Inspect) Feb 5, 2025 2:39am

@guibescos guibescos changed the title improve measurements fix: improve svm landing time metric Jan 31, 2025
@guibescos guibescos marked this pull request as ready for review January 31, 2025 04:26
danimhr
danimhr reviewed Feb 3, 2025
View reviewed changes
auction-server/src/server.rs Outdated
@@ -135,8 +135,20 @@ async fn fetch_access_tokens(db: &PgPool) -> HashMap<models::AccessTokenToken, m
.collect()
}

pub const TRANSACTION_LANDING_TIME_SVM_METRIC: &str = "transaction_landing_time_seconds_svm";
const TRANSACTION_LANDING_TIME_SVM_BUCKETS: &[f64; 14] = &[
0.1, 0.25, 0.5, 0.75, 1.0, 1.25, 1.5, 1.75, 2.0, 2.25, 2.5, 3.75, 5.0, 10.0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my bucket list suggestion:

[0.5, 1.0, 2.0, 4.0, 6.0, 8.0, 10.0, 15.0, 20.0, 30.0, 40.0, 50.0, 60.0]

We need to know more about instances more than 10 seconds.

Copy link
Contributor Author

@guibescos guibescos Feb 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m30m wanted more granularity between 1 and 2.5 because we see currently of transactions there, but I also added the 20 and 40 bucket

auction-server/src/server.rs Outdated Show resolved Hide resolved
@guibescos guibescos merged commit 44026ba into main Feb 5, 2025
2 of 3 checks passed
@guibescos guibescos deleted the chore/improve-landing-measurements branch February 5, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimhr danimhr danimhr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guibescos @danimhr